From decccb771f09936fcfff443107d2f83fb20ea9de Mon Sep 17 00:00:00 2001 From: Joshua Hoblitt Date: Wed, 21 Dec 2016 10:34:57 -0700 Subject: [PATCH 1/3] fix rspec tests Missing ::osfamily fact. --- spec/classes/init_spec.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/classes/init_spec.rb b/spec/classes/init_spec.rb index 05d37a9..417fdbc 100644 --- a/spec/classes/init_spec.rb +++ b/spec/classes/init_spec.rb @@ -1,5 +1,7 @@ require 'spec_helper' describe 'rsnapshot' do + let(:facts) {{ :osfamily => 'RedHat' }} + it { should contain_class('rsnapshot::params') } it { is_expected.to compile } end From cf50ff6251e21092a3f6a74f4919bd2f61375052 Mon Sep 17 00:00:00 2001 From: Joshua Hoblitt Date: Wed, 21 Dec 2016 10:36:49 -0700 Subject: [PATCH 2/3] fix validation warning Logic error --- templates/mysql.sh.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/mysql.sh.erb b/templates/mysql.sh.erb index 210e51f..000212b 100644 --- a/templates/mysql.sh.erb +++ b/templates/mysql.sh.erb @@ -16,7 +16,7 @@ dbs=( ) <%end-%> for db in "${dbs[@]}"; do -<% if (@dbbackup_user == 'root' && @dbbackup_password = '' )-%> +<% if (@dbbackup_user == 'root' && @dbbackup_password == '' )-%> ssh -l <%=@backup_user-%> "$host" "<%=@dumper-%> <%=@dump_flags-%> ${db}" > "$db".sql <%else-%> ssh -l <%=@backup_user-%> "$host" "<%=@dumper-%> --user=<%=@dbbackup_user-%> --password='<%=@dbbackup_password-%>' <%=@dump_flags-%> ${db}" > "$db".sql From cb04f5e70f0afbd4bb15b1d9972ce70a2f44d0d9 Mon Sep 17 00:00:00 2001 From: Joshua Hoblitt Date: Wed, 21 Dec 2016 10:42:29 -0700 Subject: [PATCH 3/3] add trivial .gitignore --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..d04d974 --- /dev/null +++ b/.gitignore @@ -0,0 +1,2 @@ +.bundle +Gemfile.lock