testing

dev/host_vars/gitea.yml

@@ -14,7 +14,6 @@ root_gpgkeys:
     id: FBF673CEEC030F8AECA814E73EDA9C3441EDA925
 
 # docker
-docker_official: true # docker's apt repos
 docker_users:
   - vagrant
 
@@ -34,7 +33,6 @@ docker_compose_deploy:
   - name: gitea
     url: https://github.com/krislamo/gitea
     version: b0ce66f6a1ab074172eed79eeeb36d7e9011ef8f
-    enabled: true
     env:
       USER_UID: "{{ users.git.uid }}"
       USER_GID: "{{ users.git.gid }}"

dev/host_vars/mediaserver.yml

@@ -5,12 +5,7 @@ allow_reboot: false
 manage_network: false
 
 users:
-  jellyfin:
+  - name: jellyfin
-    uid: 1001
-    gid: 1001
-    shell: /usr/sbin/nologin
-    home: false
-    system: true
 
 samba:
   users:

roles/base/handlers/main.yml

@@ -5,10 +5,6 @@
   listen: reboot_host
   when: allow_reboot
 
-- name: Reconfigure locales
-  ansible.builtin.command: dpkg-reconfigure -f noninteractive locales
-  listen: reconfigure_locales
-
 - name: Restart WireGuard
   ansible.builtin.service:
     name: wg-quick@wg0

roles/base/tasks/ansible.yml

@@ -2,4 +2,4 @@
   ansible.builtin.file:
     path: "~/.ansible/tmp"
     state: directory
-    mode: "700"
+    mode: 0700

roles/base/tasks/ddclient.yml

@@ -7,7 +7,7 @@
   ansible.builtin.template:
     src: ddclient.conf.j2
     dest: /etc/ddclient.conf
-    mode: "600"
+    mode: 0600
   register: ddclient_settings
 
 - name: Start ddclient and enable on boot

roles/base/tasks/firewall.yml

@@ -32,14 +32,14 @@
   ansible.builtin.template:
     src: fail2ban-ssh.conf.j2
     dest: /etc/fail2ban/jail.d/sshd.conf
-    mode: "640"
+    mode: 0640
   notify: restart_fail2ban
 
 - name: Install Fail2ban IP allow list
   ansible.builtin.template:
     src: fail2ban-allowlist.conf.j2
     dest: /etc/fail2ban/jail.d/allowlist.conf
-    mode: "640"
+    mode: 0640
   when: fail2ban_ignoreip is defined
   notify: restart_fail2ban
 

roles/base/tasks/mail.yml

@@ -11,10 +11,10 @@
   ansible.builtin.template:
     src: msmtprc.j2
     dest: /root/.msmtprc
-    mode: "600"
+    mode: 0600
 
 - name: Install /etc/aliases
   ansible.builtin.copy:
     dest: /etc/aliases
     content: "root: {{ mail.rootalias }}"
-    mode: "644"
+    mode: 0644

roles/base/tasks/network.yml

@@ -10,6 +10,6 @@
   ansible.builtin.template:
     src: "interface.j2"
     dest: "/etc/network/interfaces.d/{{ item.name }}"
-    mode: "400"
+    mode: 0400
   loop: "{{ interfaces }}"
   notify: reboot_host

roles/base/tasks/samba.yml

@@ -3,15 +3,23 @@
     name: samba
     state: present
 
+- name: Create nologin shell accounts for Samba
+  ansible.builtin.user:
+    name: "{{ item.name }}"
+    state: present
+    shell: /usr/sbin/nologin
+    createhome: false
+    system: yes
+  loop: "{{ samba.users }}"
+  when: item.manage_user is defined and item.manage_user is true
+
 - name: Create Samba users
-  ansible.builtin.command: "smbpasswd -a {{ item.name }}"
+  ansible.builtin.shell: "smbpasswd -a {{ item.name }}"
   args:
     stdin: "{{ item.password }}\n{{ item.password }}"
   loop: "{{ samba.users }}"
-  loop_control:
-    label: "{{ item.name }}"
   register: samba_users
-  changed_when: "'Added user' in samba_users.stdout"
+  changed_when: "'User added' in samba_users.stdout"
 
 - name: Ensure share directories exist
   ansible.builtin.file:
@@ -19,14 +27,13 @@
     owner: "{{ item.owner }}"
     group: "{{ item.group }}"
     state: directory
-    mode: "755"
+    mode: 0755
   loop: "{{ samba.shares }}"
 
 - name: Configure Samba shares
   ansible.builtin.template:
     src: smb.conf.j2
     dest: /etc/samba/smb.conf
-    mode: "700"
   notify: restart_samba
 
 - name: Start smbd and enable on boot

roles/base/tasks/system.yml

@@ -10,7 +10,7 @@
     state: present
 
 - name: Check for existing GPG keys
-  ansible.builtin.command: "gpg --list-keys {{ item.id }} 2>/dev/null"
+  command: "gpg --list-keys {{ item.id }} 2>/dev/null"
   register: gpg_check
   loop: "{{ root_gpgkeys }}"
   failed_when: false
@@ -18,22 +18,20 @@
   when: root_gpgkeys is defined
 
 - name: Import GPG keys
-  ansible.builtin.command:
+  command: "gpg --keyserver {{ item.item.server | default('keys.openpgp.org') }} --recv-key {{ item.item.id }}"
-    "gpg --keyserver {{ item.item.server | default('keys.openpgp.org') }} --recv-key {{ item.item.id }}"
   register: gpg_check_import
   loop: "{{ gpg_check.results }}"
   loop_control:
     label: "{{ item.item }}"
-  changed_when: false
   when: root_gpgkeys is defined and item.rc != 0
 
 - name: Check GPG key imports
-  ansible.builtin.fail:
+  fail:
     msg: "{{ item.stderr }}"
   loop: "{{ gpg_check_import.results }}"
   loop_control:
     label: "{{ item.item.item }}"
-  when: root_gpgkeys is defined and (not item.skipped | default(false)) and ('imported' not in item.stderr)
+  when: (item.skipped | default(false) == false) and ('imported' not in item.stderr)
 
 - name: Install NTPsec
   ansible.builtin.apt:
@@ -49,7 +47,7 @@
   community.general.locale_gen:
     name: "{{ locale_default }}"
     state: present
-  notify: reconfigure_locales
+  register: locale_gen_output
 
 - name: Set the default locale
   ansible.builtin.lineinfile:
@@ -57,11 +55,15 @@
     regexp: "^LANG="
     line: "LANG={{ locale_default }}"
 
+- name: Reconfigure locales
+  ansible.builtin.command: dpkg-reconfigure -f noninteractive locales
+  when: locale_gen_output.changed
+
 - name: Manage root authorized_keys
   ansible.builtin.template:
     src: authorized_keys.j2
     dest: /root/.ssh/authorized_keys
-    mode: "400"
+    mode: 0400
   when: authorized_keys is defined
 
 - name: Create system user groups
@@ -82,7 +84,6 @@
     group: "{{ item.value.gid }}"
     shell: "{{ item.value.shell | default('/bin/bash') }}"
     create_home: "{{ item.value.home | default(false) }}"
-    system: "{{ item.value.system | default(false) }}"
   loop: "{{ users | dict2items }}"
   loop_control:
     label: "{{ item.key }}"

roles/base/tasks/wireguard.yml

@@ -22,7 +22,7 @@
   ansible.builtin.template:
     src: wireguard.j2
     dest: /etc/wireguard/wg0.conf
-    mode: "400"
+    mode: 0400
   notify: restart_wireguard
 
 - name: Start WireGuard interface

roles/docker/defaults/main.yml

@@ -1,11 +1,6 @@
-docker_apt_keyring: /etc/apt/keyrings/docker.asc
-docker_apt_keyring_hash: 1500c1f56fa9e26b9b8f42452a553675796ade0807cdce11975eb98170b3a570
-docker_apt_keyring_url: https://download.docker.com/linux/debian/gpg
-docker_apt_repo: https://download.docker.com/linux/debian
 docker_compose_root: /var/lib/compose
 docker_compose_service: compose
-docker_compose: "{{ (docker_official | bool) | ternary('/usr/bin/docker compose', '/usr/bin/docker-compose') }}"
+docker_compose: /usr/bin/docker-compose
-docker_official: false
 docker_repos_keys: "{{ docker_repos_path }}/.keys"
 docker_repos_keytype: rsa
 docker_repos_path: /srv/.compose_repos

roles/docker/handlers/main.yml

@@ -21,19 +21,6 @@
   when: item.changed
   listen: compose_restart
 
-- name: Restart MariaDB
-  ansible.builtin.service:
-    name: mariadb
-    state: restarted
-  when: not mariadb_restarted
-  listen: restart_mariadb # hijack handler for early restart
-
-- name: Set MariaDB as restarted
-  set_fact:
-    mariadb_restarted: true
-  when: not mariadb_restarted
-  listen: restart_mariadb
-
 - name: Restart {{ docker_compose_service }} services
   ansible.builtin.systemd:
     state: restarted
@@ -41,14 +28,3 @@
   loop: "{{ compose_restart_list | unique }}"
   when: compose_restart_list is defined
   listen: compose_restart
-
-- name: Start {{ docker_compose_service }} services and enable on boot
-  ansible.builtin.service:
-    name: "{{ docker_compose_service }}@{{ item.name }}"
-    state: started
-    enabled: true
-  loop: "{{ docker_compose_deploy }}"
-  loop_control:
-    label: "{{ docker_compose_service }}@{{ item.name }}"
-  when: item.enabled is defined and item.enabled is true
-  listen: compose_enable

roles/docker/tasks/main.yml

@@ -1,37 +1,7 @@
-- name: Add official Docker APT key
+- name: Install Docker
-  ansible.builtin.get_url:
-    url: "{{ docker_apt_keyring_url }}"
-    dest: "{{ docker_apt_keyring }}"
-    checksum: "sha256:{{ docker_apt_keyring_hash }}"
-  when: docker_official
-
-- name: Remove official Docker APT key
-  ansible.builtin.file:
-    path: "{{ docker_apt_keyring }}"
-    state: absent
-  when: not docker_official
-
-- name: Add/remove official Docker APT repository
-  ansible.builtin.apt_repository:
-    repo: >
-      deb [arch=amd64 signed-by={{ docker_apt_keyring }}]
-      {{ docker_apt_repo }} {{ ansible_distribution_release }} stable
-    state: "{{ 'present' if docker_official else 'absent' }}"
-    filename: "{{ docker_apt_keyring | regex_replace('^.*/', '') }}"
-
-- name: Install/uninstall Docker from Debian repositories
   ansible.builtin.apt:
-    name: ['docker.io', 'docker-compose', 'containerd', 'runc']
+    name: ['docker.io', 'docker-compose']
-    state: "{{ 'absent' if docker_official else 'present' }}"
+    state: present
-    autoremove: true
-    update_cache: true
-
-- name: Install/uninstall Docker from Docker repositories
-  ansible.builtin.apt:
-    name: ['docker-ce', 'docker-ce-cli', 'containerd.io',
-           'docker-buildx-plugin', 'docker-compose-plugin']
-    state: "{{ 'present' if docker_official else 'absent' }}"
-    autoremove: true
     update_cache: true
 
 - name: Login to private registry
@@ -45,20 +15,20 @@
   ansible.builtin.file:
     path: "{{ docker_compose_root }}"
     state: directory
-    mode: "500"
+    mode: 0500
 
 - name: Install docker-compose systemd service
   ansible.builtin.template:
     src: docker-compose.service.j2
     dest: "/etc/systemd/system/{{ docker_compose_service }}@.service"
-    mode: "400"
+    mode: 0400
   notify: compose_systemd
 
 - name: Create directories to clone docker-compose repositories
   ansible.builtin.file:
     path: "{{ item }}"
     state: directory
-    mode: "400"
+    mode: 0400
   loop:
     - "{{ docker_repos_path }}"
     - "{{ docker_repos_keys }}"
@@ -69,13 +39,7 @@
     path: "{{ docker_repos_keys }}/id_{{ docker_repos_keytype }}"
     type: "{{ docker_repos_keytype }}"
     comment: "{{ ansible_hostname }}-deploy-key"
-    mode: "400"
+    mode: 0400
-    state: present
-  when: docker_compose_deploy is defined
-
-- name: Check for git installation
-  ansible.builtin.apt:
-    name: git
     state: present
   when: docker_compose_deploy is defined
 
@@ -84,7 +48,7 @@
     repo: "{{ item.url }}"
     dest: "{{ docker_repos_path }}/{{ item.name }}"
     version: "{{ item.version }}"
-    accept_newhostkey: "{{ item.accept_newhostkey | default(false) }}"
+    accept_newhostkey: "{{ item.accept_newhostkey | default('false') }}"
     gpg_whitelist: "{{ item.trusted_keys | default([]) }}"
     verify_commit: "{{ true if (item.trusted_keys is defined and item.trusted_keys) else false }}"
     key_file: "{{ docker_repos_keys }}/id_{{ docker_repos_keytype }}"
@@ -97,7 +61,7 @@
   ansible.builtin.file:
     path: "{{ docker_compose_root }}/{{ item.name }}"
     state: directory
-    mode: "400"
+    mode: 0400
   loop: "{{ docker_compose_deploy }}"
   loop_control:
     label: "{{ item.name }}"
@@ -109,9 +73,7 @@
     dest: "{{ docker_compose_root }}/{{ item.name }}/docker-compose.yml"
   delegate_to: "{{ inventory_hostname }}"
   register: compose_update
-  notify:
+  notify: compose_restart
-    - compose_restart
-    - compose_enable
   loop: "{{ docker_compose_deploy | default([]) }}"
   loop_control:
     label: "{{ item.name }}"
@@ -121,12 +83,10 @@
   ansible.builtin.template:
     src: docker-compose-env.j2
     dest: "{{ docker_compose_root }}/{{ item.name }}/.env"
-    mode: "400"
+    mode: 0400
   register: compose_env_update
-  notify:
+  notify: compose_restart
-    - compose_restart
+  no_log: "{{ docker_compose_env_nolog | default('true') }}"
-    - compose_enable
-  no_log: "{{ docker_compose_env_nolog | default(true) }}"
   loop: "{{ docker_compose_deploy }}"
   loop_control:
     label: "{{ item.name }}"
@@ -145,4 +105,13 @@
     name: docker
     state: started
     enabled: true
-  when: docker_managed | default(true)
+
+- name: Start docker-compose services and enable on boot
+  ansible.builtin.service:
+    name: "{{ docker_compose_service }}@{{ item.name }}"
+    state: started
+    enabled: true
+  loop: "{{ docker_compose_deploy }}"
+  loop_control:
+    label: "{{ docker_compose_service }}@{{ item.name }}"
+  when: item.enabled is defined and item.enabled is true

roles/docker/templates/docker-compose.service.j2

@@ -1,5 +1,5 @@
 [Unit]
-Description=%i {{ docker_compose_service }} service
+Description=%i docker-compose service
 PartOf=docker.service
 After=docker.service
 

roles/gitea/tasks/main.yml

@@ -71,3 +71,9 @@
     src: fail2ban-jail.conf.j2
     dest: /etc/fail2ban/jail.d/gitea.conf
   notify: restart_fail2ban
+
+- name: Start and enable Gitea service
+  ansible.builtin.service:
+    name: "{{ docker_compose_service }}@{{ gitea_name }}"
+    state: started
+    enabled: true

roles/mariadb/handlers/main.yml

@@ -2,11 +2,4 @@
   ansible.builtin.service:
     name: mariadb
     state: restarted
-  when: not mariadb_restarted
-  listen: restart_mariadb
-
-- name: Set MariaDB as restarted
-  set_fact:
-    mariadb_restarted: true
-  when: not mariadb_restarted
   listen: restart_mariadb

roles/mariadb/tasks/main.yml

@@ -3,10 +3,6 @@
     name: mariadb-server
     state: present
 
-- name: Set MariaDB restarted fact
-  set_fact:
-    mariadb_restarted: false
-
 - name: Regather facts for the potentially new docker0 interface
   ansible.builtin.setup: